Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide message and storage configuration in ui #2987

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Hide message and storage configuration in ui #2987

merged 2 commits into from
Apr 4, 2023

Conversation

Kelsey-Ethyca
Copy link
Contributor

Closes #2890

Code Changes

  • Set privacyDeclarationDeprecatedFields flags to false and set userCannotModify to true

Steps to Confirm

  • run fides
  • nav to management > about fides
  • verify there is no flag
  • verify there is no configuration tab under Privacy Request

Pre-Merge Checklist

allisonking
allisonking approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@cypress
Copy link

cypress bot commented Apr 4, 2023 •
edited
Loading

Passing run #1152 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge 0f2a01a into 94d41f1...
Project: fides Commit: c3d95b65e7 ℹ️
Status: Passed Duration: 00:46 💡
Started: Apr 4, 2023 5:20 PM Ended: Apr 4, 2023 5:20 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Kelsey-Ethyca Kelsey-Ethyca merged commit 1e5288a into main Apr 4, 2023
@Kelsey-Ethyca Kelsey-Ethyca deleted the KT-userCannotModify-privacyRequestsConfiguration branch April 4, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kelsey-Ethyca @allisonking